Skip to content

Add debugger tip to section "Trace a Tree Creation Site" of the contributing guide #18098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

Sporarum
Copy link
Contributor

While obvious in hindsight, there's already a lot of information to digest about the compiler, so these kinds of tips would hopefully help quite a bit

There is an argument to be made this adds even more information, but hopefully by starting with "If you are using a debugger", people who it does not concern can ignore it without burdening their mind

@Sporarum Sporarum enabled auto-merge (squash) June 29, 2023 14:06
@Sporarum Sporarum disabled auto-merge June 29, 2023 14:06
@Sporarum
Copy link
Contributor Author

I though "auto-merge (squash)" would still create a merge commit, but I'm not so sure anymore, is it okay to use it, or should I squash first and then do a normal (auto-)merge ?

@Sporarum Sporarum requested a review from bishabosha June 29, 2023 14:09
@bishabosha bishabosha merged commit 90c59bd into main Jun 29, 2023
@bishabosha bishabosha deleted the Sporarum-patch-1 branch June 29, 2023 18:10
Kordyjan added a commit that referenced this pull request Dec 8, 2023
… the contributing guide" to LTS (#19050)

Backports #18098 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants